Open
Conversation
larkox
approved these changes
Jan 13, 2022
|
LGTM, Tested Same build with Two server where 1st server had app-bar enabled and on the 2nd server app-bar was disabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it so the plugin registers its own component to the App Bar. The core webapp makes it so the component is only mounted if the
AppBarEnabledfeature flag is on. This logic is only in the core webapp, and not in the plugin's source.The plugin registers its usual channel header component, while simultaneously register the App Bar component. This is so the webapp can show one or the other when the App Bar feature flag is enabled or disabled. The plugin itself then doesn't need to watch this feature flag, and the webapp can manage the effects of the flag.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-40214